Becoming smith (request_membership, claim_membership)

Support Duniter-v2
1

As detailed in the doc (docs/user/smith.md · master · nodes / rust / Duniter v2S · GitLab), the user should become smith as soon as he requested membership and got enough certs. But it seems an additional call to claim_membership is required which is the opposite of what is documented (marked as disabled in xtask/src/gen_calls_doc.rs · master · nodes / rust / Duniter v2S · GitLab).

I do not know if I should:

  • fix the documentation
  • fix the code to avoid claim_membership call for smith also (same as main wot)

What do you think about it? Do you remember something about this?

3 Likes
2

I think I should fix the documentation:

  • request_membership → becoming smith
  • claim_membership → become member of the authorities

Maybe the latter should be renamed claim_authority or so.

3

I guess we could disable smiths_membership::claim_membership and add a an alias in the common runtime. We can’t do this directly in the pallet since it’s another instance of the same pallet for simple membership.

1 Like
4

I went for a pure documentation approach :rofl: (MR !133).

That’s what really is DDD: documentation driven development ^^

1 Like