ĞDev Runtime 702

Point de suivi

Rappel : toutes les issues sont référencées par la Milestone 702 qui sert de référence à ce qui suit :

Résumé

Depuis le dernier point, ce sont 16 nouveaux tickets qui ont été créés et ajoutés à la milestone 702 qui en comportait déjà 16, soit un total de 32 tickets. Nous avons déjà clos 10 tickets, principalement grâce au travail de @bgallois et @HugoTrentesaux. De mon côté, je suis focalisé depuis trois semaines sur #168.

Contrairement à ce que j’indiquais dans le dernier point du 05/12, pour l’instant il n’y a pas de montée en puissance des clients car le travail est focalisé sur Duniter lui-même avec de grosses modifications introduites via #156 et possiblement #168.

Enfin, les fêtes de fin d’année sont venues ralentir les développements, d’où ce point tardif 1 mois après le précédent.

Détails

Ticket #156 : modification du processus d’inscription

Parmi ces tickets, nous retrouvons le #156 ajouté récemment et qui opère un important refactoring visant à retirer la notion de “Pending Membership” qui simplifie le processus d’inscription et de maintien dans la WoT en retirant des états en blockchain, ce qui diminue le risque de bugs, simplifie la compréhension générale et facilite le travail des indexeurs.

Ce ticket supprime notamment les calls identity.validate_identity et membership.request_membership qui étaient nécessaires dans le processus d’inscription.

De plus, ce ticket voit le retour de la révocation à la Duniter v1 : un compte révoqué rend sa clé publique totalement inutilisable pour les opérations de WoT (création d’identité, certifications, adhésion). Les autres opérations, notamment le transfert de monnaie, reste exploitable.

Correction de bugs et nettoyage

Benjamin corrige quelques bugs à travers #153 et #147, mais participe aussi au nettoyage du code dans #127 et #124.

Benchmark de la palette distance

C’est l’un des gros travaux abattus par Benjamin : ajouter des poids aux calls de la palette de distance, cette dernière était encore en mode dev jusqu’à ces modifications.


Inventaire

Ouvertes

Total : 22

ID Status Assignees Title
#168 opened c-geek Have a dedicated pallet for Smith WoT
#167 opened bgallois Membership handler weight accounting
#165 opened HugoTrentesaux HandleNegativeEvaluation is never used
#164 opened HugoTrentesaux DistanceStatusExpireOn is unused
#163 opened Split OnEvent(membership_event)
#162 opened Give IdtyStatus directly in genesis
#161 opened Add live tests for membership status coherence
#160 opened Rethink revoke_membership call
#159 opened HugoTrentesaux Automatically claim membership when distance is evaluated positively
#158 opened Identity creation should only be possible for an account that already “exists”
#157 opened c-geek Ease the installation of distance Oracle
#152 opened bgallois remove random_id mechanism which is heavy and that we do not use
#151 opened c-geek AccountIdOf storage item of pallet authority-members is not used anymore
#146 opened Les comptes migrés au démarrage devraient être retirés de la pallet duniter-account
#144 opened Automatically publish ARM images of indexer
#142 opened Contribute to Cesium²
#141 opened c-geek Have a testing strategy
#128 opened bgallois Proper weights and conversion to fees
#113 opened Avoid distance computation spam
#73 opened Manually remove certification at expiration from a non-mandatory inherent
#72 opened Manually remove identity at expiration from a non-mandatory inherent
#54 opened Improve explicit revocation

Dont assignées depuis le dernier point

Total : 8

ID Status Assignees Title
#153 closed bgallois prevent linking a non-existing account
#152 opened bgallois remove random_id mechanism which is heavy and that we do not use
#150 closed c-geek Show more parameters in Genesis job
#147 closed bgallois change_owner_key ne lie pas automatiquement les comptes
#128 opened bgallois Proper weights and conversion to fees
#127 closed bgallois Remove unused errors like RightAlreadyAdded and RightNotExist
#126 closed bgallois Benchmark distance
#124 closed bgallois Remove MembersStorageIter

Dont stagnantes depuis le dernier point

Total : 8

ID Status Assignees Title
#146 opened Les comptes migrés au démarrage devraient être retirés de la pallet duniter-account
#144 opened Automatically publish ARM images of indexer
#142 opened Contribute to Cesium²
#141 opened c-geek Have a testing strategy
#113 opened Avoid distance computation spam
#73 opened Manually remove certification at expiration from a non-mandatory inherent
#72 opened Manually remove identity at expiration from a non-mandatory inherent
#54 opened Improve explicit revocation

Dont fermées depuis le dernier point

Total : 10

ID Status Assignees Title
#166 closed bgallois expire_memberships benchmark fail
#156 closed HugoTrentesaux Remove pending membership storage items and request and revoke membership calls
#155 closed HugoTrentesaux Add tests for what happens on PendingMembershipExpired
#154 closed HugoTrentesaux Tests E2E: “Pallet Sudo Call Sudo has incompatible metadata”
#153 closed bgallois prevent linking a non-existing account
#150 closed c-geek Show more parameters in Genesis job
#147 closed bgallois change_owner_key ne lie pas automatiquement les comptes
#127 closed bgallois Remove unused errors like RightAlreadyAdded and RightNotExist
#126 closed bgallois Benchmark distance
#124 closed bgallois Remove MembersStorageIter
Fichier source YAML
milestone: runtime-702
date: 2024-01-04
changes:
- title: 'Fix #166'
  mr_number: 221
- title: Remove MembersStorageIter
  mr_number: 220
- title: Refactor pallet_identity
  mr_number: 218
- title: refac membership
  mr_number: 215
- title: Fix account linking
  mr_number: 213
- title: revert benchmark removal in CI
  mr_number: 211
- title: Resolve "Tests E2E fails but CI pass"
  mr_number: 210
- title: Resolve "Show more parameters in Genesis job"
  mr_number: 209
- title: Fix/clippy on mr
  mr_number: 208
- title: Release/runtime 701
  mr_number: 207
- title: Harmonize and document events errors and calls
  mr_number: 200
issues:
- title: Have a dedicated pallet for Smith WoT
  number: 168
  status: opened
  assignees:
  - c-geek
- title: Membership handler weight accounting
  number: 167
  status: opened
  assignees:
  - bgallois
- title: '`expire_memberships` benchmark fail'
  number: 166
  status: closed
  assignees:
  - bgallois
- title: '`HandleNegativeEvaluation` is never used'
  number: 165
  status: opened
  assignees:
  - HugoTrentesaux
- title: '`DistanceStatusExpireOn` is unused'
  number: 164
  status: opened
  assignees:
  - HugoTrentesaux
- title: Split OnEvent(membership_event)
  number: 163
  status: opened
  assignees: []
- title: Give IdtyStatus directly in genesis
  number: 162
  status: opened
  assignees: []
- title: Add live tests for membership status coherence
  number: 161
  status: opened
  assignees: []
- title: Rethink revoke_membership call
  number: 160
  status: opened
  assignees: []
- title: Automatically claim membership when distance is evaluated positively
  number: 159
  status: opened
  assignees:
  - HugoTrentesaux
- title: Identity creation should only be possible for an account that already "exists"
  number: 158
  status: opened
  assignees: []
- title: Ease the installation of distance Oracle
  number: 157
  status: opened
  assignees:
  - c-geek
- title: Remove pending membership storage items and request and revoke membership calls
  number: 156
  status: closed
  assignees:
  - HugoTrentesaux
- title: Add tests for what happens on `PendingMembershipExpired`
  number: 155
  status: closed
  assignees:
  - HugoTrentesaux
- title: 'Tests E2E: "Pallet Sudo Call Sudo has incompatible metadata"'
  number: 154
  status: closed
  assignees:
  - HugoTrentesaux
- title: prevent linking a non-existing account
  number: 153
  status: closed
  assignees:
  - bgallois
- title: remove random_id mechanism which is heavy and that we do not use
  number: 152
  status: opened
  assignees:
  - bgallois
- title: AccountIdOf storage item of pallet authority-members is not used anymore
  number: 151
  status: opened
  assignees:
  - c-geek
- title: Show more parameters in Genesis job
  number: 150
  status: closed
  assignees:
  - c-geek
- title: change_owner_key ne lie pas automatiquement les comptes
  number: 147
  status: closed
  assignees:
  - bgallois
- title: Les comptes migrés au démarrage devraient être retirés de la pallet duniter-account
  number: 146
  status: opened
  assignees: []
- title: Automatically publish ARM images of indexer
  number: 144
  status: opened
  assignees: []
- title: Contribute to Cesium²
  number: 142
  status: opened
  assignees: []
- title: Have a testing strategy
  number: 141
  status: opened
  assignees:
  - c-geek
- title: Proper weights and conversion to fees
  number: 128
  status: opened
  assignees:
  - bgallois
- title: Remove unused errors like RightAlreadyAdded and RightNotExist
  number: 127
  status: closed
  assignees:
  - bgallois
- title: Benchmark distance
  number: 126
  status: closed
  assignees:
  - bgallois
- title: Remove MembersStorageIter
  number: 124
  status: closed
  assignees:
  - bgallois
- title: Avoid distance computation spam
  number: 113
  status: opened
  assignees: []
- title: Manually remove certification at expiration from a non-mandatory inherent
  number: 73
  status: opened
  assignees: []
- title: Manually remove identity at expiration from a non-mandatory inherent
  number: 72
  status: opened
  assignees: []
- title: Improve explicit revocation
  number: 54
  status: opened
  assignees: []
new_issues:
  count: 16
  issues:
  - 168
  - 167
  - 166
  - 165
  - 164
  - 163
  - 162
  - 161
  - 160
  - 159
  - 158
  - 157
  - 156
  - 155
  - 154
  - 151
unstarted_issues:
  count: 12
  issues:
  - 163
  - 162
  - 161
  - 160
  - 158
  - 146
  - 144
  - 142
  - 113
  - 73
  - 72
  - 54
taken_issues:
  count: 8
  issues:
  - 153
  - 152
  - 150
  - 147
  - 128
  - 127
  - 126
  - 124
unchanged_issues:
  count: 8
  issues:
  - 146
  - 144
  - 142
  - 141
  - 113
  - 73
  - 72
  - 54
open_issues:
  count: 22
  issues:
  - 168
  - 167
  - 165
  - 164
  - 163
  - 162
  - 161
  - 160
  - 159
  - 158
  - 157
  - 152
  - 151
  - 146
  - 144
  - 142
  - 141
  - 128
  - 113
  - 73
  - 72
  - 54
closed_issues:
  count: 10
  issues:
  - 166
  - 156
  - 155
  - 154
  - 153
  - 150
  - 147
  - 127
  - 126
  - 124
4 Likes