Hidden hardcoded Duniter variables

[HugoTrentesaux]

I’m creating this thread to list hidden hardcoded Duniter variables that should be exposed in a cleaner way (for example in pallet_config) so that we have easier control over Duniter parameters tuning.

Most of the constants are common in pallets_config.rs:

runtime/common/src/pallets_config.rs · master · nodes / rust / Duniter v2S ·...

https://git.duniter.org/nodes/rust/duniter-v2s/-/blob/master/runtime/common/src/pallets_config.rs

Some are specific to gdev, gtest, or g1. Example:

https://git.duniter.org/nodes/rust/duniter-v2s/-/blob/master/runtime/g1/src/parameters.rs

[HugoTrentesaux]

const TOKEN_DECIMALS: usize = 2;

const EXISTENTIAL_DEPOSIT: u64 = 200;

both hardcoded in chainspec, should be somewhere else

[HugoTrentesaux]

idty_name.len() >= 3
        && idty_name.len() <= 64

The bounds of identity length should be in pallet_config and not hardcoded. Without this, the wallets will not be able to get the values programmatically.

[HugoTrentesaux]

Duniter uses some environment variables. I do not consider it good practice as it is less explicit than a proper configuration file when not properly documented.

if let Ok(genesis_timestamp) = std::env::var("DUNITER_GENESIS_TIMESTAMP") {
    genesis_timestamp
        .parse()
        .map_err(|_| "DUNITER_GENESIS_TIMESTAMP must be a number".to_owned())?

Maybe the genesis timestamp could be directly in the genesis json. @poka do you know the genesis timestamp you used for ĞDev5 ? Or it can be provided by a system call like now().

[edit] actually it was the other option if genesis timestamp was not provided

use std::time::SystemTime;
SystemTime::now()
    .duration_since(SystemTime::UNIX_EPOCH)
    .expect("SystemTime before UNIX EPOCH!")
    .as_secs()

[poka]

@HugoTrentesaux

@poka do you know the genesis timestamp you used for ĞDev5 ?

No, I don’t know.
Please don’t remind me nightmares…

@poka

Quand j’essai de le faire:

    final blockHash =
        await sdk.webView!.evalJavascript('api.rpc.chain.getBlockHash(1)');
    final Map blockContent = await sdk.webView!
        .evalJavascript('api.rpc.chain.getBlock("$blockHash")');
    final String dateBrut = blockContent['block']['extrinsics'][0];

    final dateTextByte = hex.decode(dateBrut.substring(2));

    // log.d('aaaaaaaaaaaaaaaaaaaaa: $dateTextByte');
    final dateText = await sdk.webView!.evalJavascript(
        'api.tx($dateTextByte)',
        wrapPromise: false);

    log.d('aaaaaaaaaaaaaaaaaaaaa: $dateText');

Je reçois une Map vide:

I/flutter ( 3786): │ 🐛 aaaaaaaaaaaaaaaaaaaaa: {}

Pourtant je suis sur un noeud archive.

@poka

putaaaaiiinnn je veux juste la date du bloc 1 ! c’est pas dans le metadata juste sinon ??

[…]

@poka

Bon allez, balek, je passe par l’indexer

{
  block(limit: 1) {
    created_at
    number
  }
}

[HugoTrentesaux]

It seems that the genesis timestamp isn’t used anywhere else than for computing membership expiration in number of blocks. So you could not have found it. The first timestamp is the one of the first block set_timestamp event.

[poka]

@HugoTrentesaux

The first timestamp is the one of the first block set_timestamp event.

I know, but…

@poka

SCALE de mes 2.

Je comprends kedal à qu’est-ce que je dois faire de ce 0x280404000b4100a06c8401

… Je dois décoder le SCALE format à la mano ?

---

@ManUtopiK ton code ne m’aide pas trop dans l’indexer, mais merci d’avoir commenté au moins mdr

// Extract block date. Ugly, I can't find a better way to get the date of the block ?
// The only polkadot issue for that : https://github.com/polkadot-js/api/issues/2603
const created_at = new Date(
  signedBlock.block.extrinsics
    .filter(
      ({ method: { section, method } }) =>
        section === 'timestamp' && method === 'set'
    )[0]
    .args[0].toNumber()
)

Je sais pas quoi faire de ça dans mon dart…

merci pour vos éclaircissements

[HugoTrentesaux]

When you provide a runtime name you should know that its beginning determines the runtime type:

impl IdentifyRuntimeType for Box<dyn sc_chain_spec::ChainSpec> {
    fn runtime_type(&self) -> RuntimeType {
        if self.id().starts_with("g1") {
            RuntimeType::G1
        } else if self.id().starts_with("gdem") {
            RuntimeType::GTest
        } else if self.id().starts_with("dev") || self.id().starts_with("gdev") {
            RuntimeType::GDev
        } else if self.id().starts_with("gt") {
            RuntimeType::GTest
        } else {
            panic!("unknown runtime")
        }
    }
}

Who did know about “gdem” or so?

[tuxmain]

IIRC we have 2 options:

1. place them in storage, so they can be mutated by governance
   But it makes any access slower.
2. place them in runtime constants, so they can be mutated by runtime upgrade

I can’t find the issues. It could be a D-easy issue I think?

[HugoTrentesaux]

@tuxmain

IIRC

The answer might be in Liste des paramètres (protocolaires) de Duniter-v2s